Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOCKED] upgrade gix to v0.41 to fix flaky auth tests. #11831

Closed
wants to merge 1 commit into from

Commits on Apr 4, 2023

  1. Revert "Disable flaky tests for now (rust-lang#11821)"

    upgrade `gix` to v0.41 to fix flaky auth tests and revert commit c890c64.
    
    The latest release (https://github.com/Byron/gitoxide/releases/tag/gix-v0.41.0)
    makes writing to the credential helper non-fallible which is useful if the helper
    program doesn't read from stdin and is in line with of `git` implements it as well.
    
    This fix also undoes a pin `tempfile` to version 3.3 which at this time
    causes build issues for some platforms if `tempfile` version 3.4 or newer would be used.
    
    Thus this PR cannot be merged until `tempfile` will not cause build failures.
    This also means that `cargo` can't upgrade to any newer version of `gitoxide` until `tempfile` isn't an
    issue anymore, also blocking the shallow clone feature for example.
    
    @weihanglo, maybe you can replace this line with references to issues to wait for.
    Byron committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    34485e9 View commit details
    Browse the repository at this point in the history