Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: try making cargo tree's Graph from a UnitGraph #11379

Closed
wants to merge 34 commits into from
Closed

WIP: try making cargo tree's Graph from a UnitGraph #11379

wants to merge 34 commits into from

Commits on Nov 15, 2022

  1. initial failing test

    @alsuren
    alsuren committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    c0a4e8b View commit details
    Browse the repository at this point in the history

  2. skeleton Graph::from_bcx()

    @alsuren
    alsuren committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    7cab4ab View commit details
    Browse the repository at this point in the history

  3. fixme

    @alsuren
    alsuren committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    532d075 View commit details
    Browse the repository at this point in the history

  4. partially working graph::from_bcx() 

    * does not understand build dependencies
* completely ignores dev dependencies
    @alsuren
    alsuren committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    b928ab5 View commit details
    Browse the repository at this point in the history

  5. handle build dependencies by asking the resolver

    @alsuren
    alsuren committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    c4486e0 View commit details
    Browse the repository at this point in the history

  6. use CompileMode::Test to convince the resolver to give us dev-depende… 

    …ncies
    @alsuren
    alsuren committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    8679e80 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. also remove fixme about dev deps

    @alsuren
    alsuren committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    cf7dab6 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2022

  1. REVERTME: run tests with new Graph builder algorithm

    @alsuren
    alsuren committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    1a11448 View commit details
    Browse the repository at this point in the history

  2. initial support for features

    @alsuren
    alsuren committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    0677377 View commit details
    Browse the repository at this point in the history

  3. REVERTME: enable trace debugging for tests

    @alsuren
    alsuren committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    df6cd75 View commit details
    Browse the repository at this point in the history

  4. identify what the problem is with my test

    @alsuren
    alsuren committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    13c87f1 View commit details
    Browse the repository at this point in the history

  5. make test include build.rs to enable build-dependencies

    @alsuren
    alsuren committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    099e351 View commit details
    Browse the repository at this point in the history

  6. REVERTME: debug for common panic in package_for_id()

    @alsuren
    alsuren committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    c8d609f View commit details
    Browse the repository at this point in the history

  7. filter out edge kinds that were not requested

    @alsuren
    alsuren committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    d24448c View commit details
    Browse the repository at this point in the history

  8. optional: set CompileMode based on HasDevUnits

    @alsuren
    alsuren committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    6b671e9 View commit details
    Browse the repository at this point in the history

  9. fill in dep_name_map

    @alsuren
    alsuren committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    4a40877 View commit details
    Browse the repository at this point in the history

  10. copy TreeOptions::cli_features onto CompileOptions 

    test tree::features now passes
    @alsuren
    alsuren committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    161d0fb View commit details
    Browse the repository at this point in the history

  11. Revert "REVERTME: enable trace debugging for tests" 

    This reverts commit df6cd75.
    @alsuren
    alsuren committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    9e48c3d View commit details
    Browse the repository at this point in the history

  12. only populate dep_name_map when needed

    @alsuren
    alsuren committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    6ec86cb View commit details
    Browse the repository at this point in the history

  13. forward packages from TreeOptions to CompileOptions

    @alsuren
    alsuren committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    f605535 View commit details
    Browse the repository at this point in the history

  14. copy requested_kinds across, for --target

    @alsuren
    alsuren committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    40f795e View commit details
    Browse the repository at this point in the history

  15. fudge tree::filters_target test so that it passes 

    TODO: think about --target=all
    @alsuren
    alsuren committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    c25fa77 View commit details
    Browse the repository at this point in the history

  16. add build.rs to tree::invert_with_build_dep test

    @alsuren
    alsuren committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    f9e104f View commit details
    Browse the repository at this point in the history

  17. add comments for remaining test failures

    @alsuren
    alsuren committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    63446d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2022

  1. note why the rest of the tests are failing. All '-e features' and '--… 

    …target=all'
    @alsuren
    alsuren committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    e8ed11a View commit details
    Browse the repository at this point in the history

  2. handle -e features - add default feature and disable all other link t… 

    …ypes
    @alsuren
    alsuren committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    fde5f77 View commit details
    Browse the repository at this point in the history

  3. write up how features_namespaced::tree is failing

    @alsuren
    alsuren committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    fde631d View commit details
    Browse the repository at this point in the history

  4. do feature-adding properly; don't preallocate ::Feature nodes

    @alsuren
    alsuren committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    8befb2a View commit details
    Browse the repository at this point in the history

  5. don't panic on --features bar?/feat where bar is not activated

    @alsuren
    alsuren committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    a3e0932 View commit details
    Browse the repository at this point in the history

  6. hack in a Normal dep if no features asked for

    @alsuren
    alsuren committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    bde2a08 View commit details
    Browse the repository at this point in the history

  7. annotate another --target=all test

    @alsuren
    alsuren committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    3499509 View commit details
    Browse the repository at this point in the history

  8. note where tree::host_Dep_feature might be going wrong

    @alsuren
    alsuren committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    95dcd44 View commit details
    Browse the repository at this point in the history

  9. update fixmes in tests

    @alsuren
    alsuren committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    f2c6540 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. WIP on supporting --target=all via ForceAllTargets (doesn't work yet)

    @alsuren
    alsuren committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    bb9a4e2 View commit details
    Browse the repository at this point in the history