Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when an edition 2021 crate is in a virtual workspace with default resolver #10910

Merged
merged 7 commits into from
May 26, 2023
Merged

Warn when an edition 2021 crate is in a virtual workspace with default resolver #10910

merged 7 commits into from
May 26, 2023

Commits on May 26, 2023

  1. Warn when an edition 2021 crate is in a virtual workspace with defaul… 

    …t resolver

Edition 2021 updates the default resolver to version "2", but developers
using virtual workspaces commonly don't get this update because the
virtual workspace defaults to version "1". Warn when this situation
occurs so those developers can explicitly configure their workspace and
will be more likely to know that they will need to update it in the
future.
    @Nemo157
    Nemo157 committed May 26, 2023
    Configuration menu
    Copy the full SHA
    2e2b3c1 View commit details
    Browse the repository at this point in the history

  2. Detect actual edition/resolver for warning message

    @Nemo157
    Nemo157 committed May 26, 2023
    Configuration menu
    Copy the full SHA
    8b8a3a8 View commit details
    Browse the repository at this point in the history

  3. Mention workspace root's manifest explicitly

    @Nemo157
    Nemo157 committed May 26, 2023
    Configuration menu
    Copy the full SHA
    620f66f View commit details
    Browse the repository at this point in the history

  4. Update cargo new workspace inheritance tests to specify resolver

    @Nemo157
    Nemo157 committed May 26, 2023
    Configuration menu
    Copy the full SHA
    c31877d View commit details
    Browse the repository at this point in the history

  5. Improve warning message grammar

    @Nemo157
    Nemo157 committed May 26, 2023
    Configuration menu
    Copy the full SHA
    7067d0d View commit details
    Browse the repository at this point in the history

  6. Add notes on how to configure the virtual workspace's resolver

    @Nemo157
    Nemo157 committed May 26, 2023
    Configuration menu
    Copy the full SHA
    49cc60b View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary warning line

    @Nemo157
    Nemo157 committed May 26, 2023
    Configuration menu
    Copy the full SHA
    3dec6f2 View commit details
    Browse the repository at this point in the history