Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated sentence in 7.1 - Packages and Crates #3994

Closed
fmbarina opened this issue Jul 28, 2024 · 2 comments · Fixed by #4006
Closed

Duplicated sentence in 7.1 - Packages and Crates #3994

fmbarina opened this issue Jul 28, 2024 · 2 comments · Fixed by #4006
Assignees

Comments

@fmbarina
Copy link

fmbarina commented Jul 28, 2024

  • I have searched open and closed issues and pull requests for duplicates, using these search terms:
    • 7.1
    • A crate can come in one of two forms: a binary crate or a library crate.
  • I have checked the latest main branch to see if this has already been fixed, in this file:

URL to the section(s) of the book with this problem:
https://doc.rust-lang.org/stable/book/ch07-01-packages-and-crates.html

Description of the problem:

A few months back, some print changes were backported in 98165c4. I'm unsure if it was on purpose or not, so feel free to close this issue if that's the case, but this resulted in one specific sentence being duplicated/repeated very close to the original.

3rd paragraph:

A crate can come in one of two forms: a binary crate or a library crate. Binary crates are programs you can compile to an executable ...

7th paragraph

A crate can come in one of two forms: a binary crate or a library crate. A package can contain as many binary crates as you like, but at most only one library crate ...

Reading the same sentence again so quickly feels jarring. I actually thought I was on the wrong paragraph for a moment.

Suggested fix:
Remove or rephrase one of these sentences. Maybe the latter?

If this is indeed a mistake and the fix is as simple as removing it, may I open a PR?

@chriskrycho
Copy link
Contributor

Yep, looks like an error in the back-porting of changes! The trick here is that we need to make sure not merely to fix it but to actually match the change from the back port from print! @carols10cents, I’ll defer to you on that one for now, or I can pick it up when I have more time in a couple weeks.

@carols10cents carols10cents self-assigned this Jul 31, 2024
@carols10cents
Copy link
Member

😂 This is actually a problem in print 🤦🏻‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants