Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post: Changes to Rust's WASI targets #1302

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

yoshuawuyts
Copy link
Member

@yoshuawuyts yoshuawuyts commented Apr 8, 2024

This explains the upcoming changes to Rust's WASI targets, starting in Rust 1.78. This supersedes #1099. I put the post date in for 2024-04-10 (two days from now). Thanks!

cc/ @alexcrichton, @wesleywiser

Co-authored-by: Christopher Serr <christopher.serr@gmail.com>
@yoshuawuyts
Copy link
Member Author

Talked to @alexcrichton over Zulip today, and he said it looks good. I shared an earlier draft with him last week, and the version I posted here already incorporated all of his feedback. He's currently traveling though, and can't directly approve it until he's back - hence this update.

posts/2024-04-10-updates-to-rusts-wasi-targets.md Outdated Show resolved Hide resolved
posts/2024-04-10-updates-to-rusts-wasi-targets.md Outdated Show resolved Hide resolved
Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're burying the lead a bit here. This sentence might make readers wonder about why this post is on the main Rust blog instead of Inside Rust or even somewhere else. They may ask themselves "why should I read a post about a target I shouldn't use yet?".

The main story here is that there is a shift in target naming coming that will require user action, and we want to inform people as early as possible. I think that should be at the very top of the post. Let's make sure everyone knows as quickly as possible about what information they'll get from this post.

yoshuawuyts and others added 2 commits April 8, 2024 20:13
Co-Authored-By: Wesley Wiser <wwiser@gmail.com>
Co-Authored-By: Ryan Levick <ryan.levick@fermyon.com>
@yoshuawuyts yoshuawuyts force-pushed the updates-to-rusts-wasi-targets branch from 43105eb to f2baed3 Compare April 8, 2024 18:47
@yoshuawuyts
Copy link
Member Author

@rylev Those are great points, thank you. Is this better?

Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting to see the progress!

@yoshuawuyts
Copy link
Member Author

Reviews went through a lot quicker than expected - I think we're good to publish this today. Thanks everyone!

@yoshuawuyts yoshuawuyts merged commit d4c50b5 into master Apr 9, 2024
3 checks passed
@yoshuawuyts yoshuawuyts deleted the updates-to-rusts-wasi-targets branch April 9, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants