Skip to content

Commit

Permalink
Unrolled build for rust-lang#123410
Browse files Browse the repository at this point in the history
Rollup merge of rust-lang#123410 - madsmtm:relax-framework-linking-test, r=fmease

Relax framework linking test

This test was introduced by myself in rust-lang#118644, but was over-specified in that it assumed the path of the linker was always `cc`, which [causes a test failure for Chromium](https://issues.chromium.org/issues/332562251).
  • Loading branch information
rust-timer committed Apr 7, 2024
2 parents 0e3235f + de21296 commit 7493740
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tests/ui/linkage-attr/framework.omit.stderr
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
error: linking with `cc` failed: exit status: 1
error: linking with `LINKER` failed: exit status: 1
|
ld: Undefined symbols:
_CFRunLoopGetTypeID, referenced from:
Expand Down
4 changes: 3 additions & 1 deletion tests/ui/linkage-attr/framework.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@
//@ [weak]run-pass
//@ [both]run-pass

// The linker's exact error output changes between Xcode versions.
// The linker's exact error output changes between Xcode versions, depends on
// linker invocation details, and the linker sometimes outputs more warnings.
//@ compare-output-lines-by-subset
//@ normalize-stderr-test: "linking with `.*` failed" -> "linking with `LINKER` failed"
//@ normalize-stderr-test: "Undefined symbols for architecture .*" -> "ld: Undefined symbols:"
//@ normalize-stderr-test: "._CFRunLoopGetTypeID.," -> "_CFRunLoopGetTypeID,"

Expand Down

0 comments on commit 7493740

Please sign in to comment.