use LLD as the default linker #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealprof
previously approved these changes
Aug 25, 2018
|
Hi. I am a beginner. Thanks for working on this. I experienced the issue described in # 92 today. |
therealprof
previously approved these changes
Aug 28, 2018
korken89
previously approved these changes
Aug 28, 2018
|
bors r=therealprof,korken89 |
bors bot
added a commit
that referenced
this pull request
Aug 28, 2018
41: use LLD as the default linker r=therealprof,korken89 a=japaric closes #39 I added instructions on how to switch to a different linker to .cargo/config but I don't think that's too visible. Beginners are unlikely to look into that file if they run into problems with the default linker. Any suggestions to improve the visibility of that information? Also, don't merge this until the default linker changes for the Cortex-M targets on nightly as this relies on that change. r? @rust-embedded/cortex-m Co-authored-by: Jorge Aparicio <jorge@japaric.io>
Build failed |
|
Last commit should fix the build errors. re-r? |
therealprof
approved these changes
Aug 28, 2018
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 28, 2018
41: use LLD as the default linker r=therealprof a=japaric closes #39 I added instructions on how to switch to a different linker to .cargo/config but I don't think that's too visible. Beginners are unlikely to look into that file if they run into problems with the default linker. Any suggestions to improve the visibility of that information? Also, don't merge this until the default linker changes for the Cortex-M targets on nightly as this relies on that change. r? @rust-embedded/cortex-m Co-authored-by: Jorge Aparicio <jorge@japaric.io>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #39
I added instructions on how to switch to a different linker to .cargo/config but
I don't think that's too visible. Beginners are unlikely to look into that file
if they run into problems with the default linker. Any suggestions to improve
the visibility of that information?
Also, don't merge this until the default linker changes for the Cortex-M targets
on nightly as this relies on that change.
r? @rust-embedded/cortex-m