Store FFI value in enum, turn them into singletons #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, hold on, we should construct these so that object equality works. I have an idea. |
Manishearth
changed the title
|
Sweet, fixed it so that no matter how an enum gets constructed, it always uses the same object value for the same variant |
ambiguousname
approved these changes
Sep 3, 2024
feature_tests/js/api/MyEnum.d.ts
Outdated
| @@ -9,6 +9,7 @@ export class MyEnum { | |||
|
|
|||
| get ffiValue() : number; | |||
|
|
|||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more efficient as an integer and avoids hitting the maps on the hot paths.
This also cleans up the codegen to use an internal constructor. We should do more of this instead of generating complex code.