WASM Automatic Demo Generator Proof of Concept #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not really possible iwith how Javascript works
Causes some dart generation issues if set the other way
Manishearth
approved these changes
Jul 30, 2024
|
Fine to do all fixes in a followup. |
8 tasks
Moving functions into more easily documentable methods, updating documentation all around
sffc
approved these changes
Jul 30, 2024
tool/src/js/formatter.rs
Outdated
| @@ -44,7 +44,7 @@ const RESERVED: &[&str] = &[ | |||
| ]; | |||
|
|
|||
| /// Helper class for us to format JS identifiers from the HIR. | |||
| pub(super) struct JSFormatter<'tcx> { | |||
| pub struct JSFormatter<'tcx> { | |||
There was a problem hiding this comment.
Maybe?
Suggested change
| pub struct JSFormatter<'tcx> { | |
| pub(crate) struct JSFormatter<'tcx> { |
tool/src/js/mod.rs
Outdated
| @@ -15,13 +15,13 @@ use type_generation::TyGenContext; | |||
| mod layout; | |||
|
|
|||
| /// Since the main difference between .mjs and .d.ts is typing, we just want a differentiator for our various helper functions as to what's being generated: .d.ts, or .mjs? | |||
| enum FileType { | |||
| pub enum FileType { | |||
sffc
approved these changes
Jul 30, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough implementation of the process described in https://docs.google.com/document/d/1xRTmK0YtOfuAe7ClN6kqDaHyv5HpdIRIYQW6Zc_KKFU/edit?usp=sharing
Proof of concept is live at https://ambiguous.name/diplomat/