Backport recursion fix to 9.x #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing because of multiple serde MSRV breakages. Locally I can't really test because of path issues with |
|
I thought serde was fixed by a #562 :( |
|
@sanket1729 we are merging into the 9.x branch. |
LLFourn
added a commit
to frostsnap/frostsnap
that referenced
this pull request
Jul 17, 2023
LLFourn
added a commit
to frostsnap/frostsnap
that referenced
this pull request
Jul 17, 2023
LLFourn
added a commit
to frostsnap/frostsnap
that referenced
this pull request
Jul 17, 2023
LLFourn
added a commit
to frostsnap/frostsnap
that referenced
this pull request
Jul 17, 2023
LLFourn
added a commit
to frostsnap/frostsnap
that referenced
this pull request
Jul 17, 2023
LLFourn
added a commit
to frostsnap/frostsnap
that referenced
this pull request
Jul 17, 2023
darosior
added a commit
to darosior/liana
that referenced
this pull request
Jul 31, 2023
See rust-lang/rust#110475. I can't update my upstream rust-miniscript fork until rust-bitcoin/rust-miniscript#566 is merged.
|
@sanket1729 what needs to be done to move this forward? |
sanket1729
approved these changes
Aug 8, 2023
|
Tagged and published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #546. It looks like we only backported this to 7.x, not to 9.x or 8.x.
I'm not sure who is using 8.x. We should probably backport it there too. But 9.x (well, a slight fork of it) is used by elements-miniscript 1.0.
This is needed because Rust released a stable compiler with rust-lang/rust#110475 even though it breaks code that compiled fine for years and there was an open issue for 3 months.