fix: properly set socket_vmnet version #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
pendo324
force-pushed
the
fix-socket_vmnet-version
branch
from
28947fb
to
4bc7642
Compare
|
I just updated the description, it was out of date with the latest changes, trying to see why the PR title linter is failing. |
vsiravar
reviewed
Jan 25, 2023
pendo324
pushed a commit
that referenced
this pull request
Jan 26, 2023
🤖 I have created a release *beep* *boop* --- ## [0.1.2](v0.1.1...v0.1.2) (2023-01-26) ### Bug Fixes * Add command to fetch remote tags ([#26](#26)) ([71787b5](71787b5)) * properly set socket_vmnet version ([#38](#38)) ([a87d6ac](a87d6ac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Alvarez alvajus@amazon.com
Issue #, if available: runfinch/finch#21
Description of changes:
Updates the socket_vmnet target to use the submodule which fixes the version issue.
Testing done:
$ make lima-socket-vmnet $ ./_output/dependencies/lima-socket_vmnet/opt/finch/bin/socket_vmnet --version > v1.1.0-4-g910aaefLicense Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.