Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working on converting packets to ES6 along with a new portable structure #186

Merged
merged 6 commits into from
Jun 29, 2020
Merged

Working on converting packets to ES6 along with a new portable structure #186

merged 6 commits into from
Jun 29, 2020

Conversation

TheBlackParade
Copy link
Contributor

No description provided.

@TheBlackParade TheBlackParade self-assigned this Jun 23, 2020
Promises
Promises previously approved these changes Jun 23, 2020
View reviewed changes
Copy link
Collaborator

@Promises Promises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of sad to see all those typescript files go, but this is a huge improvement over the old array of sizes :shipit:

@TheBlackParade TheBlackParade marked this pull request as ready for review June 26, 2020 03:36
@TheBlackParade TheBlackParade merged commit b21ef5b into master Jun 29, 2020
@TheBlackParade TheBlackParade deleted the feature/es6-packets branch June 29, 2020 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Promises Promises Promises left review comments

Assignees

@TheBlackParade TheBlackParade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheBlackParade @Promises