test(fabric-all-in-one): fix sed write error #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade the base images to docker:24.0.2-dind which contain the fix for the cgroup v2 problems. The images built locally from this commit are pushed to ghcr.io as ghcr.io/hyperledger/cactus-fabric-all-in-one:2023-06-16-d436ef26e-issue2464-dind-v24 and ghcr.io/hyperledger/cactus-fabric2-all-in-one:2023-06-16-d436ef26e-issue2464-dind-v24 Additional context: The root cause analysis can be found here [1][2] which states that the solution is to upgrade the dind image to a version of at least 20.10.16 [1] docker-library/docker#308 [2] testcontainers/dind-drone-plugin#18 Fixes #2464 =================================== P.S.: I'm also sneaking in a hot-fix for the CI failures that are slowing down everyone else's work with false-negative checks wasting time and resources: The root package.json codegen, precodegen and postcodegen scripts are now safe from race conditions (or at least that's the theory for now). Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the base images to docker:24.0.2-dind
which contain the fix for the cgroup v2 problems.
The images built locally from this commit are pushed to ghcr.io as
ghcr.io/hyperledger/cactus-fabric-all-in-one:2023-06-16-d436ef26e-issue2464-dind-v24 and
ghcr.io/hyperledger/cactus-fabric2-all-in-one:2023-06-16-d436ef26e-issue2464-dind-v24
Additional context:
The root cause analysis can be found here [1][2]
which states that the solution is to upgrade the
dind image to a version of at least 20.10.16
[1] docker-library/docker#308
[2] testcontainers/dind-drone-plugin#18
Fixes hyperledger#2464
===================================
P.S.:
I'm also sneaking in a hot-fix for the CI failures that are slowing down everyone else's work with false-negative checks wasting time and resources: The root package.json codegen, precodegen and postcodegen scripts are now safe from race conditions (or at least that's the theory for now).