Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(klaviyo): add check for listId for subscribe #2263

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

ujjwal-ab
Copy link
Contributor

Description of the change

Add check for listId before creating the payload for subscribe endpoint if the subscribe flag is true(user wants to subscribe the profile)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@ujjwal-ab ujjwal-ab requested review from a team as code owners June 13, 2023 04:53
@ujjwal-ab ujjwal-ab requested review from utsabc and sauravlal15 and removed request for a team June 13, 2023 04:53
@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/v1.32.0@cb24f73). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v1.32.0    #2263   +/-   ##
==================================================
  Coverage                   ?   86.27%           
==================================================
  Files                      ?      497           
  Lines                      ?    25510           
  Branches                   ?     6291           
==================================================
  Hits                       ?    22008           
  Misses                     ?     3096           
  Partials                   ?      406           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ujjwal-ab ujjwal-ab merged commit 4aaac52 into release/v1.32.0 Jun 13, 2023
@devops-github-rudderstack devops-github-rudderstack deleted the klaviyo/listIdcheck branch September 14, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants