Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow null values to be passed in Braze for standard properties #2111

Merged
merged 11 commits into from
May 5, 2023

Conversation

yashasvibajpai
Copy link
Contributor

@yashasvibajpai yashasvibajpai commented May 1, 2023

Description of the change

Braze allows passing null as a traits value for standard as well as custom attributes in Identify Calls. We are adding support for standard attributes also.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@yashasvibajpai yashasvibajpai self-assigned this May 1, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (c4b0a69) 87.87% compared to head (adc27ac) 87.89%.

❗ Current head adc27ac differs from pull request most recent head 962d8c2. Consider uploading reports for the commit 962d8c2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2111      +/-   ##
===========================================
+ Coverage    87.87%   87.89%   +0.01%     
===========================================
  Files          509      509              
  Lines        25771    25769       -2     
  Branches      6380     6379       -1     
===========================================
+ Hits         22647    22649       +2     
+ Misses        2789     2787       -2     
+ Partials       335      333       -2     
Impacted Files Coverage Δ
src/v0/destinations/braze/util.js 97.14% <ø> (-0.06%) ⬇️
src/v0/destinations/braze/transform.js 84.08% <100.00%> (+1.63%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yashasvibajpai yashasvibajpai marked this pull request as ready for review May 2, 2023 06:40
@yashasvibajpai yashasvibajpai requested a review from a team as a code owner May 2, 2023 06:40
ItsSudip
ItsSudip previously approved these changes May 4, 2023
ItsSudip
ItsSudip previously approved these changes May 4, 2023
aashishmalik
aashishmalik previously approved these changes May 4, 2023
@yashasvibajpai yashasvibajpai dismissed stale reviews from aashishmalik and ItsSudip via 618bf87 May 4, 2023 20:31
@yashasvibajpai yashasvibajpai merged commit 10d037a into develop May 5, 2023
@yashasvibajpai yashasvibajpai deleted the fix.braze.allow.null.identify branch May 5, 2023 04:03
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 179 Code Smells

86.8% 86.8% Coverage
4.3% 4.3% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants