Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fb pixel): ecomm #1932

Merged
merged 14 commits into from
Mar 20, 2023
Merged

fix(fb pixel): ecomm #1932

merged 14 commits into from
Mar 20, 2023

Conversation

Gauravudia
Copy link
Contributor

Description of the change

Fixing Ecomm

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@Gauravudia Gauravudia requested a review from a team as a code owner March 10, 2023 04:46
@Gauravudia Gauravudia self-assigned this Mar 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
88% (+0.01% 🔼)
19664/22345
🟡 Branches
74.19% (+0% 🔼)
8372/11285
🟢 Functions
90.76% (-0.02% 🔻)
2209/2434
🟢 Lines
88.1% (-0% 🔻)
19500/22134
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / customTransformer.js
82.46% (+0.25% 🔼)
47.06% (-4.67% 🔻)
88.89% (-0.58% 🔻)
82.14% (-0.47% 🔻)
🟢
... / ivmFactory.js
85.19% (+0.36% 🔼)
75% (-1% 🔻)
77.27% (-0.99% 🔻)
85.98% (-0.38% 🔻)
🟢
... / customTransformer-v1.js
94%
66.67% (-6.06% 🔻)
77.78% 94%
🟢
... / index.js
92.34% (-0.12% 🔻)
84.51% (+0.37% 🔼)
100%
92.7% (-0.1% 🔻)
🟢
... / transform.js
96.72% (-0.25% 🔻)
92.31% (-0.55% 🔻)
100%
96.67% (-0.26% 🔻)
🟢
... / transform.js
94.95% (-0.15% 🔻)
62.96% 100%
94.95% (-0.15% 🔻)
🟢
... / utils.js
93.24% (-0.66% 🔻)
86.05% (-2.19% 🔻)
100%
93.24% (-0.66% 🔻)
🟢
... / transform.js
91.86% (-1.79% 🔻)
81.58% (-5.76% 🔻)
100%
91.86% (-1.79% 🔻)

Test suite run success

2601 tests passing in 179 suites.

Report generated by 🧪jest coverage report action from ea74833

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 81.00% and project coverage change: +0.03 🎉

Comparison is base (7306cd2) 87.27% compared to head (f3b46c5) 87.31%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1932      +/-   ##
===========================================
+ Coverage    87.27%   87.31%   +0.03%     
===========================================
  Files          456      456              
  Lines        24884    24896      +12     
  Branches      6241     6239       -2     
===========================================
+ Hits         21718    21737      +19     
+ Misses        2828     2822       -6     
+ Partials       338      337       -1     
Impacted Files Coverage Δ
src/constants/destinationCanonicalNames.js 100.00% <ø> (ø)
src/util/customTransformer-lambda.js 17.24% <0.00%> (ø)
src/util/utils.js 50.00% <0.00%> (ø)
src/versionedRouter.js 52.97% <0.00%> (ø)
src/v0/destinations/braze/transform.js 86.08% <92.50%> (-0.09%) ⬇️
src/util/customTransformer-faas.js 94.73% <100.00%> (ø)
src/util/customTransformer-v1.js 91.22% <100.00%> (ø)
src/util/customTransformer.js 80.30% <100.00%> (ø)
src/v0/destinations/braze/config.js 87.50% <100.00%> (-0.74%) ⬇️
...estinations/facebook_offline_conversions/config.js 100.00% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

shrouti1507
shrouti1507 previously approved these changes Mar 17, 2023
ItsSudip
ItsSudip previously approved these changes Mar 17, 2023
@Gauravudia Gauravudia dismissed stale reviews from ItsSudip and shrouti1507 via 775af7d March 17, 2023 07:21
ItsSudip
ItsSudip previously approved these changes Mar 20, 2023
shrouti1507
shrouti1507 previously approved these changes Mar 20, 2023
@Gauravudia Gauravudia removed the request for review from mihir-4116 March 20, 2023 09:40
@Gauravudia Gauravudia dismissed stale reviews from shrouti1507 and ItsSudip via fab331d March 20, 2023 10:26
shrouti1507
shrouti1507 previously approved these changes Mar 20, 2023
saikumarrs and others added 2 commits March 20, 2023 20:08
* chore: add unit test cases for handleSearch in fb pixel

---------

Co-authored-by: Gauravudia <gauravudia@rudderstack.com>
@Gauravudia Gauravudia merged commit 8d5e07a into develop Mar 20, 2023
@Gauravudia Gauravudia deleted the fix/fb_pixel-ecomm branch March 21, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants