Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: onboard courier destination (#1844) (#1883) #1899

Merged
merged 1 commit into from
Feb 27, 2023
Merged

feat: onboard courier destination (#1844) (#1883) #1899

merged 1 commit into from
Feb 27, 2023

Conversation

aashishmalik
Copy link
Contributor

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@ujjwal-ab @tk26
feat: onboard courier destination (#1844) (#1883)
18bcdf8 
* feat: onboard courier destination (#1844)

Co-authored-by: Ujjwal Abhishek <63387036+ujjwal-ab@users.noreply.github.com>

* fix: add necessary imports and fix test cases

* fix: remove courier from router

---------

Co-authored-by: tejas <6154318+tk26@users.noreply.github.com>
@aashishmalik aashishmalik requested review from anantjain45823 and mihir-4116 and removed request for a team February 27, 2023 20:52
@aashishmalik aashishmalik merged commit c5a4c8b into develop Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh sivashanmukh is a code owner

@lvrach lvrach Awaiting requested review from lvrach

@anantjain45823 anantjain45823 Awaiting requested review from anantjain45823 anantjain45823 is a code owner automatically assigned from rudderlabs/integrations

@mihir-4116 mihir-4116 Awaiting requested review from mihir-4116 mihir-4116 is a code owner automatically assigned from rudderlabs/integrations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aashishmalik @ujjwal-ab