Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set context as metadata in bugsnag error notification #1778

Merged
merged 4 commits into from
Feb 2, 2023

Conversation

saikumarrs
Copy link
Member

@saikumarrs saikumarrs commented Jan 12, 2023

Description of the change

Bugsnag groups errors based on the context and error message. It assumes a default context based on the code region where the error originated. Previously, we've been setting the context explicitly.
As a result, if the same type of error (a type error during destination transformation) occurs for multiple destinations, Bugsnag groups them together. Therefore, the notification rules and thresholds are applied as a whole group resulting in fewer alerts by shadowing other destination alerts.

Hence, the contextual information, such as (Router Transformation, Processor Transformation, etc.) is now moved to the metadata.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

N/A

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@saikumarrs saikumarrs self-assigned this Jan 12, 2023
@saikumarrs saikumarrs marked this pull request as ready for review January 12, 2023 11:15
@saikumarrs saikumarrs requested review from a team and sivashanmukh as code owners January 12, 2023 11:15
@saikumarrs saikumarrs changed the title Fix.bugsnag error notifier fix: set context as metadata in bugsnag error notification Jan 12, 2023
koladilip
koladilip previously approved these changes Jan 13, 2023
@saikumarrs saikumarrs merged commit 55c3097 into master Feb 2, 2023
@github-actions github-actions bot mentioned this pull request Feb 2, 2023
@devops-github-rudderstack devops-github-rudderstack deleted the fix.bugsnag-error-notifier branch May 1, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants