Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(destination): onboard discord #1725

Merged
merged 84 commits into from
Jan 4, 2023
Merged

feat(destination): onboard discord #1725

merged 84 commits into from
Jan 4, 2023

Conversation

anantjain45823
Copy link
Contributor

@anantjain45823 anantjain45823 commented Dec 22, 2022 •
edited
Loading

Description of the change

Onboarding new destination discord, a messaging tool, we are supporting identify and track calls in this and for every call, we are sending a message to the provided webhook URL of a discord channel following the template provided by the user for that particular event and if not, then falling back to default ones.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

saikumarrs and others added 30 commits December 7, 2022 18:36
@saikumarrs
feat: introduce new tags and error classes
0484c0f
@saikumarrs
refactor: rename function as per latest implementation
af171ab
@saikumarrs
refactor: replace ErrorBuilder with error type
777d5c8
@saikumarrs
fix: removed the ability to set stat tags externally in specific erro…
83b70d1 
…r types
@saikumarrs
feat: add destination and source ID tags
0c7a29b
@saikumarrs
refactor: rename DefaultError to BaseError
c8bdb58
@saikumarrs
fix: allow only error type and meta tags to be set in NetworkError class
157b4ca
@saikumarrs
fix: typo
90818e3
@saikumarrs
refactor: replace with new error classes in GAOC destination
00c6061
@saikumarrs
fix: remove error handling in proxy.test.js
2dd0aa6
@saikumarrs
fix: remove older stats and error types
eef0382
@saikumarrs @krishna2020
chore(core): add internal code documentation
3302e37 
Co-authored-by: Krishna Chaitanya <chaithu.kitti@gmail.com>
@saikumarrs
Merge remote-tracking branch 'origin/master' into feat.new-error-types
09a03d0
@saikumarrs
Merge branch 'feat.new-error-types' of https://github.com/rudderlabs/…
87cc0f8 
…rudder-transformer into feat.new-error-types
@saikumarrs
feat: revamp cdk V2 error handling (#1647)
047ecaf 
* feat: revamp cdk V2 error handling

* fix: revert previously committed unwanted files
@saikumarrs
refactor: replace all references of CustomError in core (#1644)
e747d5a 
* fix: do not export CustomError

* refactor: remove deprecated modules

* refactor: replace all instances of CustomError in the core module
@saikumarrs
test: fix generic proxy test suite failures (#1656)
f3f1867
@saikumarrs
refactor: use new error types (#1658)
c0a02d5 
* refactor: use new error types

* fix: use the right error type

* Revert "fix: use the right error type"

This reverts commit 2887f3a.
@ujjwal-ab
feat: refactor new error types (ga360, gainsight, gainsight_px, googl…
4f483da 
…e_cloud_function, googlepubsnub) (#1665)

* feat:[ga360] add new errorTypes

* feat:[google_cloud_function] add new errorTypes

* feat:[googlepubsnub] add new errorTypes

* feat:[gainsight_px] add new errorTypes

* feat:[gainsight] add new errorTypes
@ujjwal-ab
feat: refactor new error types (awin, blueshift, bqstream, branch, br…
3e08b1c 
…aze) (#1649)

* feat:[awin] add new error types

* feat:[blueshift] add new error types

* feat:[bqstream] add new error types

* feat:[branch] add new error types

* feat:[braze] add new error types
@ujjwal-ab
feat: refactor new error types (facebook_offline_conversions, faceboo…
5faab0c 
…k_pixel, factorsai, fb, fb_custom_audience) (#1652)

* feat:[facebook_offline_conversions] add new errorTypes

* feat:[facebook_pixel] add new errorTypes

* feat:[factorsai] add new errorTypes

* feat:[factorsai] add new errorTypes

* feat:[fb] add new errorTypes

* feat:[fb_custom_audience] add new errorTypes

* fix: refactor error  message and unit tests

* feat: update error message
@ujjwal-ab
feat: refactor new error types (custify, customerio, delighted, engag…
abddbb4 
…e, eventbridge) (#1651)

* feat:[custify] add new error types

* feat:[customerio] add new error types

* feat:[customerio] add statTags in processRouterDest

* feat:[delighted] add new errorTypes

* feat:[engage] add new errorTypes

* feat:[eventbridge] add new errorTypes
@mihir-4116
feat: new error types for destinations(mailmodo, mailchimp, lytics, l…
ace43db 
…eanplum, lambda) (#1669)

* feat: new error types for destinations

* feat: code review changes
@ujjwal-ab
feat: update new error types (#1673)
f8748ab
@mihir-4116
feat: new error types for user.com destination (#1638)
fa7b829 
* feat: new error types for user.com destination

* feat: code review changes
@mihir-4116
feat: new error types for sources (appcenter, appsflyer, braze, canny) (
db90382 
#1641)

* feat: new error types for sources

* feat: code review changes
@mihir-4116
feat: new error types for destinations (trengo, userlist, variance, v…
6fe34a0 
…ero, webengage) (#1653)

* feat: new error types for destinations

* feat: code review changes

* feat: code review changes
@mihir-4116
feat: new error types for destinations (#1661)
cf888ea
@mihir-4116
feat: new error types for destinations(persistiq, pardot, one_signal,…
3e21557 
… ometria, mssql) (#1666)

* feat: code review changes

* feat: code review changes

* feat: code review changes
@mihir-4116
feat: new error types for destinations(mixpanel, monetate, monday, mo…
4292223 
…engage, minio) (#1667)

* feat: new error types for destinations

* feat: code review changes
ItsSudip
ItsSudip reviewed Dec 26, 2022
View reviewed changes
src/v0/destinations/discord/transform.js Outdated Show resolved Hide resolved
src/v0/destinations/discord/util.js Outdated Show resolved Hide resolved
src/v0/destinations/discord/util.js Outdated Show resolved Hide resolved
src/v0/destinations/discord/util.js Outdated Show resolved Hide resolved
@anantjain45823 anantjain45823 changed the base branch from feat.new-error-types to master December 27, 2022 05:38
@anantjain45823 anantjain45823 changed the base branch from master to feat.new-error-types December 27, 2022 05:39
@anantjain45823 anantjain45823 changed the base branch from feat.new-error-types to master December 27, 2022 06:15
@yashasvibajpai
Copy link
Contributor

yashasvibajpai commented Dec 28, 2022 •
edited
Loading

We should avoid reusing utility functions from another destination, and rather accomadate any such functionalities in root-level utility functions. There can be unnecessary issues in a destination, if going ahead, some change with respect to the original destination is made in the utility function and it breaks something at the other destination.

Non blocking comment

yashasvibajpai
yashasvibajpai previously approved these changes Dec 28, 2022
View reviewed changes
@anantjain45823
Copy link
Contributor Author

We should avoid reusing utility functions from another destination, and rather accomadate any such functionalities in root-level utility functions. There can be unnecessary issues in a destination, if going ahead, some change with respect to the original destination is made in the utility function and it breaks something at the other destination.

Non blocking comment
We have used the utils file mainly and since both of them are identical destinations we are using the same transformation plan and so if there is a change in one it should reflect in the second as well to keep parity on how we support similar types of destinations.
We can keep it in global utils as well would it makes sense as only two destinations will be using it?

@anantjain45823 anantjain45823 merged commit 4f6323b into master Jan 4, 2023
@github-actions github-actions bot mentioned this pull request Jan 4, 2023
Merged
@devops-github-rudderstack devops-github-rudderstack deleted the feat.discord branch April 5, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashasvibajpai yashasvibajpai yashasvibajpai approved these changes

@ItsSudip ItsSudip ItsSudip approved these changes

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh

Assignees

@anantjain45823 anantjain45823

Labels
new-integration Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@anantjain45823 @yashasvibajpai @ItsSudip @saikumarrs @ujjwal-ab @mihir-4116 @sanpj2292 @anantrudder