Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce new tags and error classes #1631

Merged
merged 73 commits into from
Dec 20, 2022
Merged

feat: introduce new tags and error classes #1631

merged 73 commits into from
Dec 20, 2022

Conversation

saikumarrs
Copy link
Member

@saikumarrs saikumarrs commented Dec 6, 2022 •
edited
Loading

Description of the change

  • Introduced a revamped set of tags.
  • A set of new error classes is added for each significant failure scenario.
  • Default tags like destType, module, implementation etc. are now added at the version router level.
  • Removed ApiError and TransformationError classes and replaced them with the newly added classes.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

N/A

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@saikumarrs saikumarrs self-assigned this Dec 6, 2022
koladilip
koladilip reviewed Dec 7, 2022
View reviewed changes
Copy link
Contributor

@koladilip koladilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks fine

v0/destinations/clickup/util.js Outdated Show resolved Hide resolved
v0/util/errorTypes/abortedError.js Outdated Show resolved Hide resolved
@saikumarrs saikumarrs added DO NOT MERGE Don't merge this PR without having discussion DO NOT TOUCH labels Dec 7, 2022
@saikumarrs saikumarrs marked this pull request as ready for review December 8, 2022 12:14
@saikumarrs saikumarrs requested review from a team and sivashanmukh as code owners December 8, 2022 12:14
koladilip
koladilip previously approved these changes Dec 8, 2022
View reviewed changes
mihir-4116 and others added 7 commits December 15, 2022 16:07
@mihir-4116
feat: router tranform refacor for destinations (batch - 3) (#1686)
f6ca92b 
* feat: router tranform refacor

* feat: router tranform refactor

* feat: code review changes
@ujjwal-ab
feat: refactor router transformer - 1 (#1687)
03137fe 
* feat: refactor-processRouterDest

* feat: refactor-processRouterDest
@ujjwal-ab
feat: refactor-processRouterDest (#1688)
3e4f18f
@ujjwal-ab
feat: refactor-processRouterDest (#1689)
4ceaca3
@ujjwal-ab
feat: refactor router transformer - 4 (#1690)
28ddfe4 
* feat: refactor-processRouterDest

* feat: refactor-processRouterDest
@saikumarrs
fix: incorrect usages of error types (#1691)
e8ade9c 
* fix: remove all usages of TRANSFORMER_METRIC

* fixcorrect usages of error types

* feat: add assertConfig default binding

* chore: remove unwanted arguments from function definition

* chore: remove unwanted null

* chore: simplified the syntax

* fix: set default status code

* chore: use optional chaining syntax

* fix: remove unwanted status code argument
@mihir-4116
feat: destType removed (#1692)
3f6a5d2
saikumarrs
saikumarrs commented Dec 15, 2022
View reviewed changes
src/v0/destinations/active_campaign/util.js Outdated Show resolved Hide resolved
src/v0/destinations/af/deleteUsers.js Outdated Show resolved Hide resolved
src/v0/destinations/af/deleteUsers.js Outdated Show resolved Hide resolved
src/v0/destinations/af/transform.js Outdated Show resolved Hide resolved
src/v0/destinations/af/transform.js Outdated Show resolved Hide resolved
src/v0/destinations/marketo_static_list/transform.js Outdated Show resolved Hide resolved
src/v0/destinations/salesforce/transform.js Outdated Show resolved Hide resolved
src/v0/destinations/salesforce/transform.js Outdated Show resolved Hide resolved
src/v0/destinations/salesforce/transform.js Outdated Show resolved Hide resolved
src/v0/destinations/snapchat_custom_audience/utils.js Outdated Show resolved Hide resolved
ujjwal-ab and others added 7 commits December 15, 2022 22:42
@ujjwal-ab @saikumarrs
feat: refactor error types - review comments (#1697)
673b2ab 
* fix: refactor error types

* fix: rt workflow to send stat tags in pinterest tag

* fix: router transform issues in marketo_static_list

* fix: restore router transform implementation

* fix: issues in router transformation across destinations

Co-authored-by: saikumarrs <saibattinoju@rudderstack.com>
@saikumarrs
Merge branch 'master' into feat.new-error-types
266ad80
@saikumarrs
fix: final review issues (#1699)
21762c1
@sanpj2292
chore: add workspaceId as stat-tag (#1700)
314de14 
Co-authored-by: Sai Sankeerth <sanpj2292@github.com>
@saikumarrs
feat: add error handling for CDK v1 (#1698)
6caaf9d
@saikumarrs
Merge branch 'master' into feat.new-error-types
437e526
@saikumarrs
Merge branch 'master' into feat.new-error-types
c343be3
@ujjwal-ab @saikumarrs
fix: add parsed response in network error (#1704)
473d384 
* fix[gaec]: revert destination response

* fix: authErrorCategory field in the response

Co-authored-by: saikumarrs <saibattinoju@rudderstack.com>
@saikumarrs saikumarrs merged commit 0615a31 into master Dec 20, 2022
@github-actions github-actions bot mentioned this pull request Dec 20, 2022
Merged
@saikumarrs saikumarrs removed DO NOT MERGE Don't merge this PR without having discussion DO NOT TOUCH labels Feb 28, 2023
@github-actions github-actions bot deleted the feat.new-error-types branch March 20, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishna2020 krishna2020 krishna2020 left review comments

@sachin-chand-tc sachin-chand-tc sachin-chand-tc left review comments

@koladilip koladilip koladilip left review comments

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh sivashanmukh is a code owner

@aashishmalik aashishmalik Awaiting requested review from aashishmalik aashishmalik is a code owner automatically assigned from rudderlabs/integrations

@RohitKhatta RohitKhatta Awaiting requested review from RohitKhatta RohitKhatta is a code owner automatically assigned from rudderlabs/integrations

Assignees

@saikumarrs saikumarrs

Labels
Error refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@saikumarrs @sachin-chand-tc @krishna2020 @koladilip @ujjwal-ab @mihir-4116 @sanpj2292