Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(destination): onboard campaign manager #1580

Merged
merged 7 commits into from
Nov 17, 2022
Merged

feat(destination): onboard campaign manager #1580

merged 7 commits into from
Nov 17, 2022

Conversation

aashishmalik
Copy link
Contributor

Description of the change

Onboard Campaign Manager

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

ItsSudip
ItsSudip requested changes Nov 16, 2022
View reviewed changes
v0/destinations/campaign_manager/data/DCMTrackConfig.json Outdated Show resolved Hide resolved
v0/destinations/campaign_manager/data/DCMTrackConfig.json Outdated Show resolved Hide resolved
v0/destinations/campaign_manager/transform.js Outdated Show resolved Hide resolved
v0/destinations/campaign_manager/transform.js Outdated Show resolved Hide resolved
utsabc
utsabc previously approved these changes Nov 17, 2022
View reviewed changes
aashishmalik
aashishmalik commented Nov 17, 2022
View reviewed changes
v0/destinations/campaign_manager/data/CampaignManagerTrackConfig.json Outdated
Comment on lines 43 to 45
"properties.total",
"properties.value",
"properties.revenue"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

ItsSudip
ItsSudip previously approved these changes Nov 17, 2022
View reviewed changes
ItsSudip
ItsSudip previously approved these changes Nov 17, 2022
View reviewed changes
utsabc
utsabc previously approved these changes Nov 17, 2022
View reviewed changes
@aashishmalik aashishmalik dismissed stale reviews from utsabc and ItsSudip via d80f4dc November 17, 2022 10:12
@aashishmalik aashishmalik merged commit b823a53 into master Nov 17, 2022
@github-actions github-actions bot mentioned this pull request Nov 17, 2022
Merged
@github-actions github-actions bot deleted the feat/CampaignManager branch March 15, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsabc utsabc utsabc approved these changes

@ItsSudip ItsSudip ItsSudip approved these changes

@arnab-p arnab-p Awaiting requested review from arnab-p

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh sivashanmukh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aashishmalik @utsabc @ItsSudip