Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (marketo)- remove duplicate responseHandler from util and refactor #1557

Merged
merged 5 commits into from
Nov 10, 2022
Merged

fix: (marketo)- remove duplicate responseHandler from util and refactor #1557

merged 5 commits into from
Nov 10, 2022

Conversation

ujjwal-ab
Copy link
Contributor

Description of the change

Remove duplicate responseHandler function from util which is already moved to networkHandler.js and updating networkHandler.js with the changes.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@ujjwal-ab ujjwal-ab requested a review from a team as a code owner November 9, 2022 08:59
@ujjwal-ab ujjwal-ab self-assigned this Nov 9, 2022
@ujjwal-ab ujjwal-ab requested review from Gauravudia, utsabc and saikumarrs and removed request for Gauravudia November 9, 2022 08:59
@ujjwal-ab ujjwal-ab changed the title fix: (marketo)- remove duplicate responseHandler from util and refactor fix:(marketo)- remove duplicate responseHandler from util and refactor Nov 9, 2022
@ujjwal-ab ujjwal-ab changed the title fix:(marketo)- remove duplicate responseHandler from util and refactor fix: (marketo)- remove duplicate responseHandler from util and refactor Nov 9, 2022
saikumarrs
saikumarrs reviewed Nov 9, 2022
View reviewed changes
versionedRouter.js Outdated Show resolved Hide resolved
saikumarrs
saikumarrs requested changes Nov 9, 2022
View reviewed changes
Copy link
Member

@saikumarrs saikumarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert the metadata contract updates.

@ujjwal-ab ujjwal-ab merged commit 144793e into master Nov 10, 2022
@github-actions github-actions bot mentioned this pull request Nov 10, 2022
Merged
@github-actions github-actions bot deleted the fix/marketo/refactor branch March 15, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsabc utsabc utsabc approved these changes

@saikumarrs saikumarrs saikumarrs approved these changes

@arnab-p arnab-p Awaiting requested review from arnab-p

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh

@sanpj2292 sanpj2292 Awaiting requested review from sanpj2292

Assignees

@ujjwal-ab ujjwal-ab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ujjwal-ab @utsabc @saikumarrs