Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: onboard algolia destination to cdk 2.0 #1474

Merged
merged 20 commits into from
Oct 28, 2022
Merged

feat: onboard algolia destination to cdk 2.0 #1474

merged 20 commits into from
Oct 28, 2022

Conversation

saikumarrs
Copy link
Member

Description of the change

Onboard Algolia destination to CDK 2.0

  • Added error handling to router transformation handler and updated Algolia transformer to throw errors on validation failures.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

N/A

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@saikumarrs saikumarrs self-assigned this Oct 11, 2022
koladilip
koladilip reviewed Oct 12, 2022
View reviewed changes
__tests__/algolia-cdk.test.js Outdated Show resolved Hide resolved
__tests__/algolia-cdk.test.js Outdated Show resolved Hide resolved
cdk/v2/destinations/algolia/rtWorkflow.yaml Outdated Show resolved Hide resolved
versionedRouter.js Show resolved Hide resolved
versionedRouter.js Outdated Show resolved Hide resolved
koladilip
koladilip previously approved these changes Oct 26, 2022
View reviewed changes
koladilip
koladilip previously approved these changes Oct 27, 2022
View reviewed changes
saikumarrs
saikumarrs commented Oct 27, 2022
View reviewed changes
versionedRouter.js Outdated Show resolved Hide resolved
@saikumarrs saikumarrs merged commit e716d84 into master Oct 28, 2022
@github-actions github-actions bot mentioned this pull request Oct 28, 2022
Merged
@github-actions github-actions bot deleted the feat.onboard-algolia-to-cdk branch March 15, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koladilip koladilip koladilip approved these changes

@sanpj2292 sanpj2292 Awaiting requested review from sanpj2292

@arnab-p arnab-p Awaiting requested review from arnab-p

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh sivashanmukh is a code owner

@utsabc utsabc Awaiting requested review from utsabc

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507

Assignees

@saikumarrs saikumarrs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saikumarrs @koladilip