Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(marketo): unhandled exception status-code fix #1432

Merged
merged 10 commits into from
Sep 22, 2022
Merged

fix(marketo): unhandled exception status-code fix #1432

merged 10 commits into from
Sep 22, 2022

Conversation

sanpj2292
Copy link
Contributor

@sanpj2292 sanpj2292 commented Sep 20, 2022 •
edited
Loading

Description of the change

https://www.notion.so/rudderstacks/subteam-S03SHJ20350-integration-on-call-we-are-failing-to-unmarshal-some-transformer-s-responses-in-b7eee3c0393847a6b6d22fb9411924d7

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@sanpj2292 sanpj2292 requested a review from a team as a code owner September 20, 2022 16:59
@sanpj2292 sanpj2292 self-assigned this Sep 20, 2022
@sanpj2292 sanpj2292 requested review from sachin-chand-tc, RohitKhatta, a team and utsabc and removed request for sachin-chand-tc and RohitKhatta September 20, 2022 16:59
ItsSudip
ItsSudip previously approved these changes Sep 21, 2022
View reviewed changes
utsabc
utsabc previously approved these changes Sep 21, 2022
View reviewed changes
@sanpj2292 sanpj2292 dismissed stale reviews from utsabc and ItsSudip via a5b4211 September 21, 2022 14:43
saikumarrs
saikumarrs previously approved these changes Sep 22, 2022
View reviewed changes
@sanpj2292 sanpj2292 merged commit 6cc4868 into master Sep 22, 2022
@github-actions github-actions bot mentioned this pull request Oct 12, 2022
Merged
@github-actions github-actions bot deleted the fix.api-err-handle-mkto branch March 15, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsSudip ItsSudip ItsSudip approved these changes

@saikumarrs saikumarrs saikumarrs approved these changes

@utsabc utsabc utsabc left review comments

Assignees

@sanpj2292 sanpj2292

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sanpj2292 @utsabc @ItsSudip @saikumarrs