fix(cdkv1): error handling for cdkv1 destinations (#2227)

* fix: error handling for cdkv1 destinations Signed-off-by: Sai Sankeerth <sanpj2292@github.com> * fix: modified failure test-case for zapier service integration test Signed-off-by: Sai Sankeerth <sanpj2292@github.com> --------- Signed-off-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Sai Sankeerth <sanpj2292@github.com>
rudderlabs · Jun 1, 2023 · c3aedbf · c3aedbf
1 parent 6732f5e
commit c3aedbf
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/src/cdk/v1/handler.js b/src/cdk/v1/handler.js
@@ -81,4 +81,5 @@ async function processCdkV1(destType, parsedEvent) {
 
 module.exports = {
   processCdkV1,
+  getErrorInfo,
 };
diff --git a/src/services/destination/cdkV1Integration.ts b/src/services/destination/cdkV1Integration.ts
@@ -1,4 +1,4 @@
-import { ConfigFactory, Executor } from 'rudder-transformer-cdk';
+import { ConfigFactory, Executor, RudderBaseConfig } from 'rudder-transformer-cdk';
 import path from 'path';
 import IntegrationDestinationService from '../../interfaces/DestinationService';
 import {
@@ -16,6 +16,7 @@ import {
 import { TransformationError } from '../../v0/util/errorTypes';
 import DestinationPostTransformationService from './postTransformation';
 import tags from '../../v0/util/tags';
+import { getErrorInfo } from '../../cdk/v1/handler';
 
 export default class CDKV1DestinationService implements IntegrationDestinationService {
   public init() {
@@ -49,6 +50,15 @@ export default class CDKV1DestinationService implements IntegrationDestinationSe
     return metaTO;
   }
 
+  private async processCDKV1(event: any, tfConfig: RudderBaseConfig): Promise<any> {
+    try {
+      const respEvents = await Executor.execute(event, tfConfig);
+      return respEvents;
+    } catch (error) {
+      throw getErrorInfo(error);
+    }
+  }
+
   public async doProcessorTransformation(
     events: ProcessorTransformationRequest[],
     destinationType: string,
@@ -59,7 +69,7 @@ export default class CDKV1DestinationService implements IntegrationDestinationSe
     const respList: ProcessorTransformationResponse[][] = await Promise.all(
       events.map(async (event) => {
         try {
-          const transformedPayloads: any = await Executor.execute(event as any, tfConfig);
+          const transformedPayloads: any = await this.processCDKV1(event as any, tfConfig);
           // We are not passing destinationHandler to post processor as we don't have post processing in CDK flows
           return DestinationPostTransformationService.handleProcessorTransformSucessEvents(
             event,

diff --git a/test/__tests__/integration/data_scenarios/cdk_v1/failure.json b/test/__tests__/integration/data_scenarios/cdk_v1/failure.json
@@ -148,8 +148,8 @@
         "sourceDefinitionId": "1b6gJdqOPOCadT3cddw8eidV591",
         "destinationDefinitionId": ""
       },
-      "statusCode": 500,
-      "error": "Unsupported \"channel\": \"offline\". It must be one of: web,server,mobile,sources",
+      "statusCode": 400,
+      "error": "Unknown error occurred. Original error: Unsupported \"channel\": \"offline\". It must be one of: web,server,mobile,sources",
       "statTags": {
         "errorCategory": "transformation",
         "destType": "ZAPIER",