fix: flaky volunteers & supervisors system specs

[thejonroberts]

What github issue is this PR for, if any?

No issue -- I have seen this spec cause failures locally and in CI.

What changed, and why?

spec/system/volunteers/index_spec.rb :55 & :400 were the most common failures, roughly 90% of my local runs I would guess. I was running specs in 'defined' order, not random, and I think it was happening more consistently that way.

I ran some rubocop-capybara auto fixes while troubleshooting - figured I may as well leave those changes in for good measure.

It seems like the travel_to calls were the major culprit. Adding travel_backs helped, but I do not see why they are necessary, so I just removed them. The other major issue was the sign_out -> visit -> sign_in -> visit sequence, the spec would get kicked out to the sign in page. I changed the sequence to a refresh call. I think a page refresh still properly tests the feature?

[elasticspoon]

Looks reasonable. Should we just add rubocop-capybara to the app? I personally often mess up the to_not have_x vs to have_no_x

[thejonroberts]

Looks reasonable. Should we just add rubocop-capybara to the app? I personally often mess up the to_not have_x vs to have_no_x

Yes, I think that would be great to add! I always always have to double check things like that. So I have it as a global gem for my IDE.

I'm not sure how to hook that up with standardrb, but I I could poke around this week. I do know you can use standard via rubocop, so that is an option.

I also think standard-rails/rubocop-rails would be great to add. I actually implemented it earlier this week, but I didn't want to overwhelm you 😆 . Here's a PR for standard-rails if you're curious. -- I think it's just too much change at the moment.