Faster tests #98
Merged
Faster tests #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the slowest test in the suite, taking longer than 1 second. I had the logic duplicated for some weird reason, removing that got me twice as fast. Since we need to boot 2 processes (the slow process), we can spawn them both before waiting on the first one to finish.
Total test time is now 3.78
Booting processes is slow. Total test time is now 3.37
Shelling out to the executable is very expensive. Moving this logic into the class means we can unit test it which is much faster. Total test time is now 1.72 seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce total test time from 4.71 to 1.76 seconds.