Strip HEREDOC #19
Merged
Strip HEREDOC #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heredocs in ruby are common sources of indentation even though they cannot cause either an "unmatched" or "unexpected" end syntax errors. To help avoid these false positives when parsing source, we first find and parse all heredocs. If the lines that contain the heredocs are valid, they'll be commented-out/hidden early on. This drastically decreases the chance that heredoc based indentation will lead to false positives.
schneems
force-pushed
the
schneems/handle-heredocs
branch
from
42ec76c
to
b3478aa
Compare
schneems
added a commit
that referenced
this pull request
Jan 15, 2022
# This is the 1st commit message: Move queue logic and engulf logic to a class The queuing and engulfing logic are tied together. We can bundle the two of them into a single class with a specific interface. # This is the commit message #2: WIP A*ish # This is the commit message #3: WIP with lex_diff OMG # This is the commit message #4: WIP Pull out "grab equal" logic of UpDownExpand # This is the commit message #5: WIP move class to proper file location # This is the commit message #6: WIP Fix spelling of method # This is the commit message #7: WIP LOL search # This is the commit message #8: Runs, finds the large code blocks, but is too greedy # This is the commit message #9: Move LexDiff to own class, refactor to an array We're never using the hash keys so we don't need them. We can save memory and time by storing the values as an array. # This is the commit message #10: WIP LOL spec # This is the commit message #11: Micro optimize lex diff # This is the commit message #12: UpDownExpand fix major bug with internal mutability When calling `line.lex_detect.dup` it was duplicating the outer memory, but not the inner memory. Internally we're using an array and the old array was still being referenced and mutated. # This is the commit message #13: LexDiff Huge perf upgrade Store values in the object instead of an array. # This is the commit message #14: WIP playing with fuzzing this into the old algorithm # This is the commit message #15: WORKS and is hella fast # This is the commit message #16: WIP docs # This is the commit message #17: Put a max band on number of iterations Unbounded while loops scare me, in theory this class should never iterate more than line times, but mistakes happen. When they do I want feedback for the user without disrupting the rest of their program. # This is the commit message #18: WIP Cleanup and docs # This is the commit message #19: WIP Cleanup and docs # This is the commit message #20: Standardrb # This is the commit message #21: Standardrb # This is the commit message #22: Refactor LexDiff, remove unused methods, add docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heredocs in ruby are common sources of indentation even though they cannot cause either an "unmatched" or "unexpected" end syntax errors. To help avoid these false positives when parsing source, we first find and parse all heredocs. If the lines that contain the heredocs are valid, they'll be commented-out/hidden early on. This drastically decreases the chance that heredoc based indentation will lead to false positives.