Rename DeadEnd -> SyntaxSuggest #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/syntax_suggest
branch
2 times, most recently
from
e05b789
to
a7f34da
Compare
Based on this conversation (https://bugs.ruby-lang.org/issues/18159#note-29) I was asked to change the name of DeadEnd because it might sound scary. This name is more meaningful as it represents what it does. It suggests the location of syntax errors.
schneems
force-pushed
the
schneems/syntax_suggest
branch
from
fb9d069
to
b57fe7f
Compare
|
@schneems Huge thanks for your thoughts and work ❤️ |
|
It worthed to be mentioned in the README, I guess. It's quite strange to watch for a project, or maybe even search for it by old memories, and found nothing, but very similar with very different name without mentions of renaming. Also I remind about VS Code plugins. |
|
@AlexWayfer hope this is helpful a30db92. Also, @mauro-oto, I'm not sure how to move forward with the vscode plugin if we change the CLI name. |
|
@schneems I think it's OK, anyway better than nothing, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this conversation (https://bugs.ruby-lang.org/issues/18159#note-29) I was asked to change the name of DeadEnd because it might sound scary. This name is more meaningful as it represents what it does. It suggests the location of syntax errors.