Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[changelog skip] Refactor: Immutable CodeBlocks #13

Merged
merged 1 commit into from
Nov 16, 2020
Merged

[changelog skip] Refactor: Immutable CodeBlocks #13

merged 1 commit into from
Nov 16, 2020

Commits on Nov 16, 2020

  1. Refactor: Immutable CodeBlocks 

    To be able to have CodeBlock class not depend on knowledge of all code lines, we need to move the code expansion logic outside of the code class.

It's now being represented in the BlockExpand class which can be independently tested. To simplify writing this class, a helper class AroundBlockScan was introduced. This class automates some of the chores around searching before/after a given block.

The IndentScan class has been renamed to ParseBlocksFromIndentLine to be a little more descriptive about it's purpose and goal, but I'm still struggling to name it.
    @schneems
    schneems committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    abfd59c View commit details
    Browse the repository at this point in the history