Fix source.match performance without specifying term string #186
+25
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Jul 30, 2024
lib/rexml/source.rb
Outdated
Comment on lines
250
to
252
| # Note: When specifying a string for 'pattern', it must not include '>' except in the following formats: | ||
| # - ">" | ||
| # - "XXX>" (X is any string excluding '>') |
There was a problem hiding this comment.
Could you remove this outdated comment?
| @@ -240,7 +250,9 @@ def ensure_buffer | |||
| # Note: When specifying a string for 'pattern', it must not include '>' except in the following formats: | |||
| # - ">" | |||
| # - "XXX>" (X is any string excluding '>') | |||
| def match( pattern, cons=false, term: nil ) | |||
| def match( pattern, cons=false ) | |||
There was a problem hiding this comment.
Style. Very minor: the spaces around the argument list does not match the other methods in the file.
There was a problem hiding this comment.
Yes. We should use a consistent coding style in the same code base. But it's out-of-scope of this pull request. We should work on it separately.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance problem of
source.match(regexp)was recently fixed by specifying terminator string. However, I think maintaining appropriate terminator string for a regexp is hard.I propose solving this performance issue by increasing bytes to read in each iteration.