test: Fix invalid XML with spaces before the XML declaration #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
changed the title
|
Good catch! But the important part in the specification is difference. The part you cited explains about an element (e.g. https://www.w3.org/TR/2006/REC-xml11-20060816/#document
It doesn't have https://www.w3.org/TR/2006/REC-xml11-20060816/#NT-prolog
It doesn't have https://www.w3.org/TR/2006/REC-xml11-20060816/#NT-XMLDecl
It doesn't have Could you update the PR description? |
[Why] XML declaration allowed only at the start of the document. https://www.w3.org/TR/2006/REC-xml11-20060816/#document ``` [1] document ::= ( prolog element Misc* ) - ( Char* RestrictedChar Char* ) ``` It doesn't have `S*` before `prolog`. https://www.w3.org/TR/2006/REC-xml11-20060816/#NT-prolog ``` [22] prolog ::= XMLDecl Misc* (doctypedecl Misc*)? ``` It doesn't have `S*` before `XMLdecl`. https://www.w3.org/TR/2006/REC-xml11-20060816/#NT-XMLDecl ``` [23] XMLDecl ::= '<?xml' VersionInfo EncodingDecl? SDDecl? S? '?>' ``` It doesn't have `S*` before `'<?xml'`.
naitoh
force-pushed
the
fixed_invalid_xml_with_spaces_before_the_xml_declaration_in_the_test_code
branch
from
49a6fa4
to
50a91a6
Compare
|
@kou |
|
Thanks! |
naitoh
deleted the
fixed_invalid_xml_with_spaces_before_the_xml_declaration_in_the_test_code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
XML declaration allowed only at the start of the document.
https://www.w3.org/TR/2006/REC-xml11-20060816/#document
It doesn't have
S*beforeprolog.https://www.w3.org/TR/2006/REC-xml11-20060816/#NT-prolog
It doesn't have
S*beforeXMLdecl.https://www.w3.org/TR/2006/REC-xml11-20060816/#NT-XMLDecl
It doesn't have
S*before'<?xml'.