Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add section Methods for Working with JSON #275

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

BurdetteLamar
Copy link
Member

The linked methods are weakly documented at present, but stronger doc is already in a PR over at JSON.

@peterzhu2118 peterzhu2118 merged commit 6e9c24b into ruby:master Dec 6, 2023
47 checks passed
@mrkn
Copy link
Member

mrkn commented Dec 6, 2023

@peterzhu2118 Wait, why did you merge this without the maintainer confirmation?

These are methods added by json.gem, right? So, these description should put in the documentation of json.gem.

@peterzhu2118
Copy link
Member

Sorry, I should not have merged without maintainer's approval.

These are methods added by json.gem, right? So, these description should put in the documentation of json.gem.

Yes, but since they add these methods to the BigDecimal class, I don't think we can put the documentation in the JSON gem due to RDoc limitations. For example, in the documentation BigDecimal#to_json appears as a method that is in BigDecimal.

@mrkn
Copy link
Member

mrkn commented Dec 6, 2023

Alright, I understand that we need to include them in this repository. Therefore, I think it's important to note that 'json/add/bigdecimal' is provided by the json.gem. What are your thoughts?

@peterzhu2118
Copy link
Member

I opened #278 to add this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants