Stub out extension build on JRuby #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note this should also let us start to source the .rb files from the gem rather than versioning them in the JRuby repository. The last step will be moving our native BigDecimal implementation into the gem, which will hopefully happen some time this year. |
headius
force-pushed
the
jruby_bigdecimal
branch
from
b27443d
to
c772eef
Compare
JRuby currently ships its own internal bigdecimal extension as part of the core libraries. In order for users to be able to add bigdecimal to their Gemfile or gem dependencies, we need to stub out the C extension and just load the extension shipped with JRuby. In the future we will try to move our BigDecimal implementation into the gem, but for now this is the simplest way to make it installable on JRuby. See ruby#169
headius
force-pushed
the
jruby_bigdecimal
branch
from
c772eef
to
977eb84
Compare
Migration of the Java native BigDecimal into this repo will force us to handle both C and Java implementations at the same time when we add a new feature and fix some behavior. I want to avoid this situation. |
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JRuby currently ships its own internal bigdecimal extension as part of the core libraries. In order for users to be able to add bigdecimal to their Gemfile or gem dependencies, we need to stub out the C extension and just load the extension shipped with JRuby.
In the future we will try to move our BigDecimal implementation into the gem, but for now this is the simplest way to make it installable on JRuby.
See #169