Enhanced RDoc for selected methods #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrkn, I don't want to put up anything more until you've had a chance to comment on this PR. That will give me good guidance going forward. |
mrkn
reviewed
Nov 23, 2021
| * | ||
| * Examples: | ||
| * | ||
| * BigDecimal('111111.111').add(1, 0) # => 0.111112111e6 |
There was a problem hiding this comment.
@BurdetteLamar Could you please add the line to specify the rounding mode explicitly before this line?
There was a problem hiding this comment.
@BurdetteLamar Could you please use :half_up instead of BigDecimal::ROUND_HALF_UP because I want to promote using a symbol instead of a constant?
There was a problem hiding this comment.
Done. But I have used :half_up (the default) because that's how the examples were made.
By the way, I strongly agree that the symbol is better.
|
@mrkn, is this ready to merge? |
|
Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treated:
A couple of things I've made consistent with usage over at ruby/ruby:
add, I've calledndigits.Document-methodis not needed.I also discovered that
+andaddare different, and have documented them separately.