Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lookups of 0 keys #594

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Fix lookups of 0 keys #594

merged 1 commit into from
Jan 3, 2022

Conversation

movermeyer
Copy link
Contributor

@movermeyer movermeyer commented Dec 16, 2021

What are you trying to accomplish?

Fixes #593

#457 introduced a bug where 0 was no longer considered an integer, and so lookups of 0 keys failed.

What approach did you choose and why?

Fixed the regex to allow 0, and added more test coverage.

What should reviewers focus on?

🤷 Alright regex?

The impact of these changes

Lookups of keys that end in .0 will work once again.

@movermeyer movermeyer changed the title Support ±0 as a key Fix lookups of 0 keys Dec 16, 2021
@radar
Copy link
Collaborator

radar commented Jan 3, 2022

Looks good to me, thank you :)

@radar radar merged commit 3a5ad2a into ruby-i18n:master Jan 3, 2022
@oleksii-leonov
Copy link
Contributor

@movermeyer, thnx for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot look up keys that end in .0
3 participants