Remove references to default_locale in fallbacks comment
#576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#415 changed the behaviour, but this comment was not updated to reflect the change.
tjoyal
approved these changes
Sep 2, 2021
|
cc @radar Awaiting your review 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
#415 changed the behaviour, but this comment was not updated to reflect the change.
What approach did you choose and why?
Minimal changes to the documentation comment.
What should reviewers focus on?
I don't have the depth of knowledge in this area to know if there is more that should change in this comment.
The impact of these changes
People will hopefully get less confused when they read the comment (won't go looking for some non-existent code somehow using the
default_locale).cc @radar
Checklist