[Fix #454] Fix false positives for Performance/BigDecimalWithNumericArgument
#463
Conversation
…NumericArgument` Fixes rubocop#454. This PR fixes false positives for `Performance/BigDecimalWithNumericArgument` when using BigDecimal 3.1+. The bad and good examples for this cop are reversed between BigDecimal 3.0 and 3.1. Since BigDecimal 3.1 is the default gem in Ruby 3.1, this PR reverses the bad and good examples when targeting Ruby 3.1+. So, the goal of this PR is to address many cases where the meaning was entirely reversed. To avoid introducing excessive complexity related to version dependencies, detection is disabled for Ruby 3.0 and below. Ideally, a solution that prioritizes the BigDecimal version would be best in the future, but this PR does not take that into account.
| class BigDecimalWithNumericArgument < Base | ||
| extend AutoCorrector | ||
| extend TargetRubyVersion | ||
|
|
||
| minimum_target_ruby_version 3.1 |
There was a problem hiding this comment.
Can you use requires_gem API here? bigdecimal is becoming a bundled gem so many already have it in their lockfile and the ruby version is barely relevant anymore. This would stop this cop from doing something if the user doesn't use bundler, or for those who somehow don't have it in their lockfile yet but I think this is the way to go
There was a problem hiding this comment.
Ideally, a solution that prioritizes the BigDecimal version would be best in the future, but this PR does not take that into account.
As the testing methodology for that approach doesn't seem to be established, it is not included in this PR. The focus is currently on resolving the more common cases.
There was a problem hiding this comment.
Ah, right. You already meant requires_gem wit with that
koic
deleted the
fix_false_positives_for_performance_big_decimal_with_numeric_argument
branch
Fixes #454.
This PR fixes false positives for
Performance/BigDecimalWithNumericArgumentwhen using BigDecimal 3.1+.The bad and good examples for this cop are reversed between BigDecimal 3.0 and 3.1.
Since BigDecimal 3.1 is the default gem in Ruby 3.1, this PR reverses the bad and good examples when targeting Ruby 3.1+. So, the goal of this PR is to address many cases where the meaning was entirely reversed.
To avoid introducing excessive complexity related to version dependencies, detection is disabled for Ruby 3.0 and below.
Ideally, a solution that prioritizes the BigDecimal version would be best in the future, but this PR does not take that into account.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.