Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #289] count asserts within blocks for assignments #291

Merged
merged 1 commit into from
Jan 1, 2024
Merged

[Fix #289] count asserts within blocks for assignments #291

merged 1 commit into from
Jan 1, 2024

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Dec 31, 2023

Follow up to #290 / #289 - I realised when re-reviewing my change that assertion_method? only checks the immediate expression of assignments, which makes sense for what it's meant to be doing - so we need to still handle checking the bodies of blocks for assignments.

I've not added a changelog for this since the original PR has not been released so I figured it would still be considered a single "fix", but let me know if you'd still like a second changelog entry anyway.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic merged commit 48a64ae into rubocop:master Jan 1, 2024
13 checks passed
@koic
Copy link
Member

koic commented Jan 1, 2024

Thanks!

@G-Rath G-Rath deleted the fix-assertion-count-again branch January 2, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants