Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress a Ruby 3.4's obsoleted warning in test #314

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

koic
Copy link
Member

@koic koic commented Sep 4, 2024

This PR suppresses the following Ruby 3.4's obsoleted warning in test:

$ ruby -v
ruby 3.4.0dev (2024-09-01T11:00:13Z master eb144ef91e) [x86_64-darwin23]

$ bundle exec rspec spec/rubocop/ast/node_spec.rb:320
(snip)

/Users/koic/src/github.com/rubocop/rubocop-ast/spec/rubocop/ast/node_spec.rb:320:
warning: URI::RFC3986_PARSER.make_regexp is obsoleted. Use URI::RFC2396_PARSER.make_regexp explicitly.

This PR suppresses the following Ruby 3.4's obsoleted warning in test:

```console
$ ruby -v
ruby 3.4.0dev (2024-09-01T11:00:13Z master eb144ef91e) [x86_64-darwin23]

$ bundle exec rspec spec/rubocop/ast/node_spec.rb:320
(snip)

/Users/koic/src/github.com/rubocop/rubocop-ast/spec/rubocop/ast/node_spec.rb:320:
warning: URI::RFC3986_PARSER.make_regexp is obsoleted. Use URI::RFC2396_PARSER.make_regexp explicitly.
```
@marcandre marcandre merged commit 108811b into rubocop:master Sep 4, 2024
19 checks passed
@koic koic deleted the suppress_obsoleted_warning_in_test branch September 4, 2024 16:01
@marcandre
Copy link
Contributor

Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants