Add RuboCop::AST::RationalNode
#304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR resolves the fundamental issue mentioned in rubocop/rubocop#13051. Although rational literal (e.g., `(0.2r)` is a basic literal that return `true` for `RuboCop::AST::Node#numeric_type?` and `RuboCop::AST::Node#literal?`, their behavior was not sufficiently covered as a `NumericNode`. This PR maps rational literal to `RationalNode` to enable expected node operations for rational literals.
koic
added a commit
to koic/rubocop
that referenced
this pull request
Jul 17, 2024
Fixes rubocop#13051. This PR fixes an error for `Lint/FloatComparison` when comparing with rational literal. NOTE: Using rubocop/rubocop-ast#304 in the future will allow for a more fundamental resolution of the issue.
koic
added a commit
to koic/rubocop
that referenced
this pull request
Jul 17, 2024
Fixes rubocop#13051. This PR fixes an error for `Lint/FloatComparison` when comparing with rational literal. NOTE: Using rubocop/rubocop-ast#304 in the future will allow for a more fundamental resolution of the issue.
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
Jul 17, 2024
Fixes rubocop#13051. This PR fixes an error for `Lint/FloatComparison` when comparing with rational literal. NOTE: Using rubocop/rubocop-ast#304 in the future will allow for a more fundamental resolution of the issue.
bbatsov
pushed a commit
to rubocop/rubocop
that referenced
this pull request
Jul 17, 2024
Fixes #13051. This PR fixes an error for `Lint/FloatComparison` when comparing with rational literal. NOTE: Using rubocop/rubocop-ast#304 in the future will allow for a more fundamental resolution of the issue.
|
@marcandre Can you review this? |
|
Sorry, I missed the notification, thanks for the reminder. Looks great, thanks. |
|
Thank you @marcandre! |
|
Released as 1.32.0 |
koic
added a commit
to koic/rubocop
that referenced
this pull request
Aug 5, 2024
Follow up rubocop/rubocop-ast#304 This PR requires RuboCop AST 1.32.0+ to use `RuboCop::AST::RationalNode` instead of workaround logic.
8 tasks
bbatsov
pushed a commit
to rubocop/rubocop
that referenced
this pull request
Aug 6, 2024
Follow up rubocop/rubocop-ast#304 This PR requires RuboCop AST 1.32.0+ to use `RuboCop::AST::RationalNode` instead of workaround logic.
koic
added a commit
to koic/rubocop
that referenced
this pull request
Aug 7, 2024
Follow up rubocop/rubocop-ast#304 This PR requires RuboCop AST 1.32.0+ to use `RuboCop::AST::RationalNode` instead of workaround logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the fundamental issue mentioned in rubocop/rubocop#13051. Although rational literal (e.g.,
(0.2r)is a basic literal that returntrueforRuboCop::AST::Node#numeric_type?andRuboCop::AST::Node#literal?, their behavior was not sufficiently covered as aNumericNode.This PR maps rational literal to
RationalNodeto enable expected node operations for rational literals.