Make Node#class_constructor? aware of Data.define and numbered parameters
#255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.2 introduced immutable `Data.define`. Since this is similar to `Struct.new`, `Node#class_constructor` will handle it in the same way.
`Class.new`, `Module.new`, `Struct.new`, and `Data.define` take themselves as a block parameter. These are the same when using numbered block parameter.
koic
changed the title
Node#class_constructor aware of Data.define and numbered parametersNode#class_constructor? aware of Data.define and numbered parameters
marcandre
reviewed
Feb 11, 2023
| { | ||
| (send #global_const?({:Class :Module :Struct}) :new ...) | ||
| (send #global_const?(:Data) :define ...) | ||
| ({block numblock} { |
There was a problem hiding this comment.
This is good, but makes me wonder if we shouldn't have a pseudo type to include both of these... Maybe any_block or a_block instead of {block numblock}
|
Thanks! 🚀 |
|
Released as 1.26 |
koic
added a commit
to rubocop/rubocop
that referenced
this pull request
Feb 11, 2023
Follow up rubocop/rubocop-ast#255. `RuboCop::AST::Node#class_constructor?` has been introduced in RuboCop AST 1.26.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following two commits:
Make
Node#class_construcor?aware of Ruby 3.2'sData.defineRuby 3.2 introduced immutable
Data.define. Since this is similar toStruct.new,Node#class_constructorwill handle it in the same way.Make
Node#class_constructor?aware of Ruby 2.7's numbered parametersClass.new,Module.new,Struct.new, andData.definetake themselves as a block parameter.These are the same when using numbered block parameter.
I will try to update rubocop/rubocop#11546 and rubocop/rubocop#11547 with this feature.