Move ProcessedSource#sorted_tokens to be a public method
#195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Released in 1.9.0 👍 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of cops are not detecting issues when looking at tokens around heredocs (for instance
Layout/SpaceInsideParams) because they use pairs of tokens, but the tokens are not sorted properly for heredocs as method arguments (as per the comment ofProcessedSource#sorted_tokens).For instance, this space is not detected by
Layout/SpaceInsideParamscurrently because the tokens are not sorted in the expected order:This change just moves that method to be public so that the cops can use it.