Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodePattern: Set optimization #111

Closed
wants to merge 1 commit into from
Closed

Conversation

marcandre
Copy link
Contributor

This builds on #110 to optimize NodePattern with unions of literals like (send nil? {:method :other_method})

> rake compile '{1 2 3}'
# before:
(1 === node || 2 === node || 3 === node)
# after:
::RuboCop::AST::NodePattern::Sets::SET_1_2_3 === node

And SET_1_2_3 is set to Set[1, 2, 3]

@marcandre
Copy link
Contributor Author

Merged 🎉 . To be released tomorrow.

@marcandre marcandre closed this Sep 27, 2020
@marcandre marcandre deleted the set_optimization branch September 27, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant