Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] optional workspace parameters unit test add #200

Closed

Conversation

SuZhou-Joe
Copy link
Collaborator

@SuZhou-Joe SuZhou-Joe commented Sep 23, 2023

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

gaobinlong and others added 4 commits September 20, 2023 13:31
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
…oject#189)

* feat: optimize logic when checkConflict and bulkCreate

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add options.workspace check

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: throw error when workspace check error in repository create

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: modify judgement

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: always get objects from DB when create-with-override

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe changed the base branch from main to workspace-pr-integr September 23, 2023 10:29
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2023

Codecov Report

Merging #200 (e8c0298) into workspace-pr-integr (d7d712e) will decrease coverage by 0.06%.
Report is 4 commits behind head on workspace-pr-integr.
The diff coverage is 51.48%.

@@                   Coverage Diff                   @@
##           workspace-pr-integr     #200      +/-   ##
=======================================================
- Coverage                66.49%   66.44%   -0.06%     
=======================================================
  Files                     3408     3408              
  Lines                    65149    65238      +89     
  Branches                 10431    10466      +35     
=======================================================
+ Hits                     43323    43349      +26     
- Misses                   19237    19281      +44     
- Partials                  2589     2608      +19     
Flag Coverage Δ
Linux_1 ?
Linux_2 ?
Linux_3 ?
Linux_4 ?
Windows_1 ?
Windows_2 ?
Windows_3 ?
Windows_4 ?
_1 34.81% <ø> (?)
_2 55.40% <51.48%> (?)
_3 44.47% <0.99%> (?)
_4 34.80% <0.99%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../core/public/saved_objects/saved_objects_client.ts 92.55% <ø> (ø)
...ore/server/saved_objects/import/check_conflicts.ts 100.00% <ø> (ø)
...rver/saved_objects/import/resolve_import_errors.ts 96.42% <ø> (ø)
...d_objects/migrations/core/build_active_mappings.ts 87.09% <ø> (ø)
...e/server/saved_objects/serialization/serializer.ts 100.00% <100.00%> (ø)
...saved_objects/service/lib/search_dsl/search_dsl.ts 100.00% <ø> (ø)
src/core/server/saved_objects/service/lib/utils.ts 100.00% <100.00%> (ø)
...erver/saved_objects/import/create_saved_objects.ts 96.77% <0.00%> (-3.23%) ⬇️
...erver/saved_objects/import/import_saved_objects.ts 97.50% <50.00%> (-2.50%) ⬇️
src/core/server/saved_objects/routes/export.ts 15.00% <0.00%> (ø)
... and 9 more

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe marked this pull request as draft September 25, 2023 02:14
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe marked this pull request as ready for review September 27, 2023 02:06
@SuZhou-Joe SuZhou-Joe marked this pull request as draft September 27, 2023 02:07
@SuZhou-Joe SuZhou-Joe closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants