Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for workspace core service #191

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

ruanyl
Copy link
Owner

@ruanyl ruanyl commented Sep 21, 2023

Description

Added unit tests for core WorkspacesService

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Merging #191 (d7e2691) into workspace-pr-integr (855c3a8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@                   Coverage Diff                   @@
##           workspace-pr-integr     #191      +/-   ##
=======================================================
+ Coverage                66.44%   66.47%   +0.02%     
=======================================================
  Files                     3408     3408              
  Lines                    65149    65155       +6     
  Branches                 10431    10431              
=======================================================
+ Hits                     43291    43311      +20     
+ Misses                   19264    19249      -15     
- Partials                  2594     2595       +1     
Flag Coverage Δ
Linux_ 66.05% <100.00%> (+0.02%) ⬆️
_1 34.81% <50.00%> (+<0.01%) ⬆️
_2 55.42% <100.00%> (+0.07%) ⬆️
_3 44.58% <50.00%> (+<0.01%) ⬆️
_4 34.88% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/core/public/mocks.ts 59.09% <ø> (ø)
src/core/public/workspace/workspaces_service.ts 96.29% <ø> (+59.25%) ⬆️
src/core/public/core_system.test.mocks.ts 100.00% <100.00%> (ø)
src/core/public/core_system.ts 91.95% <100.00%> (+0.09%) ⬆️
...c/core/public/workspace/workspaces_service.mock.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl ruanyl force-pushed the test-for-workspace-core-service branch from a0fecc7 to d7e2691 Compare September 22, 2023 07:50
@ruanyl ruanyl merged commit 3dcea50 into workspace-pr-integr Sep 22, 2023
65 checks passed
ruanyl added a commit that referenced this pull request Sep 22, 2023
+ workspace integration branch pr patch

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl added a commit that referenced this pull request Sep 22, 2023
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl added a commit that referenced this pull request Sep 25, 2023
rename workspace service class name and types

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl added a commit that referenced this pull request Sep 28, 2023
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl added a commit that referenced this pull request Oct 13, 2023
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants