Use namedAccounts in hardhat deploy #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will use the namedAccounts for testnet and mainnet as they are already deployed.
For the moment we have multiSig, wrappedCurrency, proxyAdmin.
We will need to add the rest of the proxies to this list
Also removed chainId: 1 from hardhat network, it was there before as some tests had chainId = 1 because of a bug on ganachehttps://github.com/trufflesuite/ganache/issues/451
This is not the case anymore, and using chainId:1 takes the namedAccounts from mainnet, so we removed that