Create a flyover redeem script builder #2727
Conversation
Remove unused import Remove mistaken reason Minor refactor Make flyover rs builder receive a keccak256 hash instead of sha256 one Refactors
…o RedeemScriptCreationException
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rskj-core/src/main/java/co/rsk/peg/bitcoin/FlyoverRedeemScriptBuilderImpl.java
Fixed
Show fixed
Hide fixed
|
|
||
| @ParameterizedTest | ||
| @MethodSource("invalidDerivationHashArgsProvider") | ||
| void addFlyoverDerivationHashToRedeemScript_withInvalidPrefix_shouldThrowFlyoverRedeemScriptCreationException(Keccak256 flyoverDerivationHash) { |
There was a problem hiding this comment.
WDYT about improving test name adding whenInvalidPrefix?:
addFlyoverDerivationHashToRedeemScript_whenInvalidPrefix_shouldThrowFlyoverRedeemScriptCreationException
| } | ||
|
|
||
| @Test | ||
| void addFlyoverDerivationHashToRedeemScript_shouldReturnRedeemScriptWithFlyoverDerivationHash() { |
There was a problem hiding this comment.
whenValidFlyoverDerivationHash? WDYT?:
addFlyoverDerivationHashToRedeemScript_whenValidFlyoverDerivationHash_shouldReturnRedeemScriptWithFlyoverDerivationHash
rskj-core/src/main/java/co/rsk/peg/bitcoin/FlyoverRedeemScriptBuilderImpl.java
Outdated
Show resolved
Hide resolved
| import co.rsk.bitcoinj.script.Script; | ||
| import co.rsk.crypto.Keccak256; | ||
|
|
||
| public interface FlyoverRedeemScriptBuilder { |
There was a problem hiding this comment.
Why merge it into the master branch instead of the integration branch, wip/fed-scripts-refactors-integration?
There was a problem hiding this comment.
Makes it easier to integrate all the changes we are working on in different branches
|
Description
Create a flyover redeem script builder to be used in substitution of the one provided by bitcoinj-thin. Looking to decouple Bridge related logic from bitcoinj-thin
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: