Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setPitch, proper indenting #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added setPitch, proper indenting #50

wants to merge 1 commit into from

Conversation

vincurekf
Copy link

I've just added Wad.prototype.setPitch() (it was not possible to set pitch to single wad on playback), and tried to correct indenting in code and unify it a bit to be easily readable.

I've just added Wad.prototype.setPitch() (as it was not possible to set pitch to single wad on playback, and tryed to correct indeting in code and unify it a bit to be easily readable.
@rserota
Copy link
Owner

rserota commented Oct 19, 2015

I'm not sure what you mean by "proper" indenting. I think 2-space indentations and 4-space indentations are equally valid, but I personally find it uncomfortable to read code with 2-space indentations. I appreciate that you're adding a feature, but please leave the indentation and other aspects of formatting as they were.

@phal0r
Copy link

phal0r commented Aug 1, 2016

@rserota

Considering indentations, I would suggest tabs instead of whitespaces, so everybody can adjust his/her editor to display indentation as desired without changing the source code.

@julianpoy
Copy link

julianpoy commented Aug 1, 2016

@phal0r When joining a new repository, it is typically the developers job to adapt to the coding standards and layout of the project.

@phal0r
Copy link

phal0r commented Aug 4, 2016

@julianpoy

Yeah, I totally agree. I didn't change it, I was just suggesting a good way :)

@rserota
Copy link
Owner

rserota commented Jul 2, 2020

@phal0r WadJS has been updated to use tabs instead of spaces. Thanks for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants