Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add support for multiple Access-Control-Request-Headers field (fixes #184) #186

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

jub0bs
Copy link
Contributor

@jub0bs jub0bs commented Aug 29, 2024

As discussed in #184 (comment), I've implemented a fix that tolerates a small amount of whitespace around elements and a small number of empty elements:

const (
	maxOWSBytes      = 1  // number of leading/trailing OWS bytes tolerated
	maxEmptyElements = 16 // number of empty list elements tolerated
)

@rs Let me know whether those values are acceptable or should be modified.

internal/sortedset.go Outdated Show resolved Hide resolved
internal/sortedset.go Outdated Show resolved Hide resolved
@rs rs merged commit a814d79 into rs:master Aug 29, 2024
@jub0bs
Copy link
Contributor Author

jub0bs commented Aug 29, 2024

Thanks for merging so quickly. Don't forget to release a new tagged version 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants